feat: --watch, -w, watch is prior to config's watch #736
Conversation
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 4bed09b 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6206d4e41f2e3000074f57b4 😎 Browse the preview: https://deploy-preview-736--vitest-dev.netlify.app |
There was a problem hiding this comment.
This PR does fix watch flags not working at all if a config value is used, so that's good.
However, even with the --watch flag, tests are still shown as RUN and not WATCH in the CLI. So the best approach would have been #717, i.e., setting correct default values.
|
@DerYeger What is your suggestion on this PR then? |
I'd merge it, since it fixes the broken behavior. |
|
@DerYeger Thanks, let's see if the team agrees. |
| options.api = resolveApiConfig(options) | ||
| options.watch = options.watch && !options.run | ||
| if (isWatchArg()) |
There was a problem hiding this comment.
Having the plugin coupled with CLI argv is probably not a good idea. I will take another try
Resolves #727