New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --shard command #1477
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"name": "@vitest/test-shard", | ||
"private": true, | ||
"scripts": { | ||
"test": "vitest run shard-test.test.ts" | ||
}, | ||
"devDependencies": { | ||
"execa": "^6.1.0", | ||
"vitest": "workspace:*" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
import { expect, test } from 'vitest' | ||
import { basename } from 'pathe' | ||
import { execa } from 'execa' | ||
|
||
const runVitest = async (args: string[]) => { | ||
const { stdout } = await execa('vitest', ['--run', '--dir', './test', ...args]) | ||
return stdout | ||
} | ||
|
||
const parsePaths = (stdout: string) => { | ||
return stdout | ||
.split('\n') | ||
.filter(line => line && line.includes('.test.js')) | ||
.map(file => basename(file.trim().split(' ')[1])) | ||
.sort() | ||
} | ||
|
||
test('--shard=1/1', async () => { | ||
const stdout = await runVitest(['--shard=1/1']) | ||
|
||
const paths = parsePaths(stdout) | ||
|
||
expect(paths).toEqual(['1.test.js', '2.test.js', '3.test.js']) | ||
}) | ||
|
||
test('--shard=1/2', async () => { | ||
const stdout = await runVitest(['--shard=1/2']) | ||
|
||
const paths = parsePaths(stdout) | ||
|
||
expect(paths).toEqual(['1.test.js', '2.test.js']) | ||
}) | ||
|
||
test('--shard=2/2', async () => { | ||
const stdout = await runVitest(['--shard=2/2']) | ||
|
||
const paths = parsePaths(stdout) | ||
|
||
expect(paths).toEqual(['3.test.js']) | ||
}) | ||
|
||
test('--shard=4/4', async () => { | ||
const stdout = await runVitest(['--shard=4/4']) | ||
|
||
const paths = parsePaths(stdout) | ||
|
||
// project only has 3 files | ||
// shards > 3 are empty | ||
expect(paths).toEqual([]) | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { expect, test } from 'vitest' | ||
|
||
test('1', () => expect(1).toBe(1)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { expect, test } from 'vitest' | ||
|
||
test('2', () => expect(1).toBe(1)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import { expect, test } from 'vitest' | ||
|
||
test('3', () => expect(1).toBe(1)) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import { defineConfig } from 'vitest/config' | ||
|
||
export default defineConfig({ | ||
test: { | ||
testTimeout: 50_000, | ||
}, | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to just throw the error, as
resolveConfig
can be used programmatically, and the caller might want to catch the error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a bug, when throwing an error, process doesn't stop 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can catch it and process.exit in the caller, instead of having side-effect for
resolveConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added throwing, but I still do
process.exit
when catching the error