Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: respect transformMode when resolving id #1506

Merged
merged 6 commits into from Jun 21, 2022
Merged

fix: respect transformMode when resolving id #1506

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
953ed55
fix: consider transform mode when resolving ids
sheremet-va Jun 19, 2022
0d4d1de
test: testing resolveId
sheremet-va Jun 19, 2022
085b0a5
chore: cleanup
sheremet-va Jun 19, 2022
2225b57
chore: use importer to get transform mode when resolving id
sheremet-va Jun 20, 2022
9904b9d
Merge branch 'main' of https://github.com/vitest-dev/vitest into fix/…
sheremet-va Jun 21, 2022
b986d25
chore: update lockfile
sheremet-va Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vite-node/src/server.ts
View file
Open in desktop
Expand Up @@ -54,7 +54,8 @@ export class ViteNodeServer {
async resolveId(id: string, importer?: string): Promise<ViteNodeResolveId | null> {
if (importer && !importer.startsWith(this.server.config.root))
importer = join(this.server.config.root, importer)
return this.server.pluginContainer.resolveId(id, importer, { ssr: true })
const mode = (importer && this.getTransformMode(importer)) || 'ssr'
return this.server.pluginContainer.resolveId(id, importer, { ssr: mode === 'ssr' })
}

async fetchModule(id: string): Promise<FetchResult> {
Expand Down