feat: support vite 3 #1543
Closed
feat: support vite 3 #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for vitest-dev failed.
|
sheremet-va
commented
Jun 25, 2022
| @@ -2,7 +2,7 @@ | |||
| /// <reference types="vite/client" /> | |||
|
|
|||
| import { defineConfig } from 'vite' | |||
| import solid from 'solid-start' // or use 'vite-plugin-solid' instead | |||
| import solid from 'vite-plugin-solid' // or use 'vite-plugin-solid' instead | |||
There was a problem hiding this comment.
We can remove comment now
sheremet-va
commented
Jun 25, 2022
| @@ -20,6 +20,7 @@ const extraInlineDeps = [ | |||
| /@vitest\/dist/, | |||
| // Nuxt | |||
| '@nuxt/test-utils', | |||
| /vite\w*\/dist\/client\/env.mjs/, | |||
There was a problem hiding this comment.
This is backported to #1546
|
It seems to take some time to wait for the stable release of Vite 3. Can we just release a major beta version of Vitest? Then we can use Vite 3 in Vitest. Since Vite 2.x doesn't accept feature PR vitejs/vite#8769 now. |
We already support Vite 3, this is PR for updating mostly examples |
|
Oh, I see. So can we merge this PR #1540 now? |
Sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Vite 3
TODO