Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make fallbackCJS mode try resolve from /es/... path to /lib/... path #1633

Merged
merged 2 commits into from Jul 16, 2022
Merged

feat: make fallbackCJS mode try resolve from /es/... path to /lib/... path #1633

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e52426
fix: fallbackCJS mode now support to try find from `/es/...` to `/lib…
zthxxx Jul 10, 2022
87483e9
chore: update
antfu Jul 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vite-node/src/externalize.ts
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@ import type { DepsHandlingOptions } from './types'
import { slash } from './utils'

const ESM_EXT_RE = /\.(es|esm|esm-browser|esm-bundler|es6|module)\.js$/
const ESM_FOLDER_RE = /\/esm\/(.*\.js)$/
const ESM_FOLDER_RE = /\/(es|esm)\/(.*\.js)$/

const defaultInline = [
/virtual:/,
Expand Down Expand Up @@ -32,6 +32,7 @@ export function guessCJSversion(id: string): string | undefined {
for (const i of [
id.replace(ESM_FOLDER_RE, '/umd/$1'),
id.replace(ESM_FOLDER_RE, '/cjs/$1'),
id.replace(ESM_FOLDER_RE, '/lib/$1'),
zthxxx marked this conversation as resolved.
Show resolved Hide resolved
id.replace(ESM_FOLDER_RE, '/$1'),
]) {
if (existsSync(i))
Expand Down