New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter out Symbol.hasInstance #1757
Conversation
97b486e
to
469232c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unfortunately doesn't seem to quite be enough to fix #1671.... at least fully. After manually applying this patch locally, my tests started failing with TypeError: Cannot read properties of undefined (reading 'dataEmitted')
. jsdom
test environment in a very basic vue3 app.... oddly, dataEmitted
doesn't seem to appear anywhere in my node_modules tree.
emmm.... I tried to find the reason and converted the PR into draft |
This |
Wow, good find! I forgot to mention I was doing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like this solution. There are valid cases where we do want to mock Symbol.hasInstance
, and, as you've noticed, this doesn't actually fix the root cause.
I'm working on a fix for the underlying issue which should be up shortly.
fix #1671