fix: auto-mock based on descriptor list, not property keys (fix #1671) #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-dev#1671) These two methods seem like they should be the same, but they're not. Some objects, especially native Node exports, behave strangely; they have properties that are enumerated by `Object.getOwnPropertyNames()` and/or `Object.getOwnPropertySymbols()`, but when you try to get the descriptor for that property using `Object.getOwnPropertyDescriptor()` it returns `undefined`. To combat this, instead of getting the property names / symbols manually, we instead offload that work to the JS engine itself via `Object.getOwnPropertyDescriptors`, and just iterate through the result. Fixes vitest-dev#1671
|
Hmm... That didn't seem to work quite as smoothly as I'd hoped... Back to the drawing board I guess! |
simon-abbott
force-pushed
the
another-automock-fix
branch
from
8bf0540
to
aff8330
Compare
|
Closed in favor of #1786. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two methods seem like they should be the same, but they're not. Some objects, especially native Node exports, behave strangely; they have properties that are enumerated by
Object.getOwnPropertyNames()and/orObject.getOwnPropertySymbols(), but when you try to get the descriptor for that property usingObject.getOwnPropertyDescriptor()it returnsundefined. To combat this, instead of getting the property names / symbols manually, we instead offload that work to the JS engine itself viaObject.getOwnPropertyDescriptors, and just iterate through the result.Fixes #1671