fix: better bundling of types #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for a way to fully ignore |
I found a wonderful flag |
antfu
reviewed
Aug 4, 2022
| @@ -25,6 +25,7 @@ | |||
| "test:ci": "cross-env CI=true pnpm -r --stream --filter !test-fails --filter !test-browser run test --allowOnly", | |||
| "test:ci:single-thread": "cross-env CI=true pnpm -r --stream --filter !test-fails run test --allowOnly --no-threads", | |||
| "typecheck": "tsc --noEmit", | |||
| "typecheck:why": "tsc --noEmit --explainFiles > explainTypes.txt", | |||
There was a problem hiding this comment.
Wanted to keep it in case someone will mess up the types again 👀
antfu
approved these changes
Aug 4, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the bundle size (and time for
build), since we no longer bundle the sameVitesttype (and its dependencies).Before:
After:
Possible fix for #1619?