Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle unsettable keys during automocking #1786

Merged
merged 1 commit into from Aug 5, 2022

Commits on Aug 4, 2022

  1. fix: gracefully handle unsettable keys during automocking (fix vitest…

    …-dev#1671)
    
    Sometimes while automocking we will encounter a property that, for some
    unknown reason, throws an error when you try to define it. Unfortunately
    I can't figure out _why_ it errors, so instead I have opted to quietly
    skip these unsettable properties. If that becomes a problem in the
    future this can be revisited, but I don't forsee it being an issue since
    these keys are mostly deeply internal prototype stuff that 99.999% of
    people don't even know exists, let alone want to mock. Plus, if you
    _really_ need to have this behavior you can always use `__mocks__` or
    just shim it inline yourself.
    simon-abbott committed Aug 4, 2022
    Copy the full SHA
    aff8330 View commit details
    Browse the repository at this point in the history