Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): better local test context support #1799

Closed
wants to merge 2 commits into from
Closed

feat(types): better local test context support #1799

wants to merge 2 commits into from

Conversation

Tanimodori
Copy link
Contributor

fix #1798.

This pr only changes types, no underlying JavaScript codes are altered.

This pr passed build and all tests on my local machine.

sheremet-va
sheremet-va requested changes Aug 5, 2022
View reviewed changes
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more tests with examples please? Other then that LGTM 👍🏻

@Tanimodori
Copy link
Contributor Author

Tanimodori commented Aug 5, 2022 •
edited

Thanks, I've found a better approach without changing the ChainableFunction signature (since it is exported and may be troublesome for dependencies). Resolved conficts and also added a unit test. I'll open another pr soon.

Edit: Reopened as #1805

@Tanimodori Tanimodori closed this Aug 5, 2022
@Tanimodori Tanimodori mentioned this pull request Aug 5, 2022
Merged
@Tanimodori Tanimodori deleted the feat-local-context-type branch August 6, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Types: Better local test context support
2 participants
@Tanimodori @sheremet-va