Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim URL parameters from file paths in coverage #1843

Closed

Conversation

OrestHk
Copy link
Contributor

@OrestHk OrestHk commented Aug 12, 2022

No description provided.

@sheremet-va
Copy link
Member

I think PR #1841 tries to do the same, but in a different way? @ChpShy

@OrestHk
Copy link
Contributor Author

OrestHk commented Aug 12, 2022

Hello, I've tried #1841, the problem is that it will indead remove the error, but also remove the .ts file from the coverage result list, keeping only the .vue file in the result
This is only a draft ATM, but the following seems to allow to keep both ts and vue file in the coverage result, with the creation of the HTML file in the html reporter

@PatrickChen928
Copy link
Contributor

Yes, you are right. This is not v0.21.1's bug, to be precise, this is v0.16.x's bug.In v0.16.0, testing.ts is skipped. And I misunderstood it.

@sheremet-va
Copy link
Member

Coverage is now implemented in different packages. @OrestHk do you think the fix is needed, or we can close this PR?

@OrestHk
Copy link
Contributor Author

OrestHk commented Oct 10, 2022

Tried with vitest 0.24.1 and @vitest/coverage-c8 the problem is still here
I'll close this PR and look into @vitest/coverage-c8 to see what can be done !

@OrestHk OrestHk closed this Oct 10, 2022
@OrestHk
Copy link
Contributor Author

OrestHk commented Oct 20, 2022

@sheremet-va I openned a new PR #2181, as this one is a bit stale and I add a bit of trouble with the lock file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants