Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: workaround test-ui ci failure #1942

Merged
merged 3 commits into from Aug 31, 2022
Merged

chore: workaround test-ui ci failure #1942

merged 3 commits into from Aug 31, 2022

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 31, 2022

Try to solve test ui hanging. Merge it if all went green.

@antfu antfu changed the title chore: rebuild lock chore: workaround test-ui ci failure Aug 31, 2022
@antfu antfu merged commit b4aad6a into main Aug 31, 2022
@antfu antfu deleted the chore/rebuild-lock branch August 31, 2022 08:09
@antfu
Copy link
Member Author

antfu commented Aug 31, 2022

For reference: cypress-io/cypress#22795

@sheremet-va
Copy link
Member

sheremet-va commented Aug 31, 2022

For reference: cypress-io/cypress#22795

16.16 doesn't have a fix for node segfaults :S

But I guess it's only for UI, so 😄

@lmiller1990
Copy link

lmiller1990 commented Sep 1, 2022

Do you intend to try to support Node.js 16.17 or just recommend against using it? It seems 16.17, specifically noted here: nodejs/node#42623 (comment) introduced a breaking change.

I am looking at support for Node.js 18.6 for Cypress which has the same issue. I will let you know if I find a fix.

@sheremet-va
Copy link
Member

Do you intend to try to support Node.js 16.17 or just recommend against using it? It seems 16.17, specifically noted here: nodejs/node#42623 (comment) introduced a breaking change.

I am looking at support for Node.js 18.6 for Cypress which has the same issue. I will let you know if I find a fix.

Vitest supports Node 16.17 (we have registerNodeLoader option, which has shortCircuit property), this is just for running Cypress tests 😄

@lmiller1990
Copy link

Hmm interesting, I think you won't need that anymore once cypress-io/cypress#23637 lands -- we just needed to update our ts-node internally.

I could be mistaken, though. Also -- what do you mean "for running Cypress tests"? Ohhhh - I see you are using Cypress to test the Vitest UI?

If this is correct that is very cool, I can contribute/help out in some way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants