Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct source maps in stacktrace #2027

Merged
merged 17 commits into from Oct 7, 2022
Merged

fix: use correct source maps in stacktrace #2027

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
24d1086
[vitest] use correct source maps in stacktrace
haikyuu Sep 12, 2022
6f67d3d
[vitest] refactor
haikyuu Sep 12, 2022
455a93f
add tests for stack traces and sourcemaps
haikyuu Sep 12, 2022
efd5dc6
commit lockfile
haikyuu Sep 12, 2022
82059db
fix linter
haikyuu Sep 12, 2022
4e8a276
fix types linter
haikyuu Sep 12, 2022
c117e6f
remove dynamic content from snapshot
haikyuu Sep 12, 2022
5d2ee1c
push the correct snapshot
haikyuu Sep 12, 2022
a2dfde5
fix tests :)
haikyuu Sep 12, 2022
dc9306e
Merge branch 'main' into fix-incorrect-sourcemap
haikyuu Sep 12, 2022
cf278e9
increase timeout for runner tests
haikyuu Sep 12, 2022
e623579
decrease timeout .. not the culprit in CI
haikyuu Sep 12, 2022
60b5467
move continue below map assignment
haikyuu Sep 12, 2022
ea2a473
guard against accessing vitenode server
haikyuu Sep 13, 2022
6362066
reduce the size of snapshots
haikyuu Sep 13, 2022
1475f4a
Merge branch 'main' into fix-incorrect-sourcemap
haikyuu Sep 15, 2022
76eb12f
rename timeout to prevent running more than one
haikyuu Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 7 additions & 3 deletions packages/vitest/src/utils/source-map.ts
View file
Open in desktop
Expand Up @@ -25,10 +25,14 @@ export async function interpretSourcePos(stackFrames: ParsedStack[], ctx: Vitest
for (const frame of stackFrames) {
if ('sourcePos' in frame)
continue
const transformResult = ctx.server.moduleGraph.getModuleById(frame.file)?.ssrTransformResult
if (!transformResult)
const ssrTransformResult = ctx.server.moduleGraph.getModuleById(frame.file)?.ssrTransformResult
const transformResult = ctx.server.moduleGraph.getModuleById(frame.file)?.transformResult
const result = ssrTransformResult || transformResult
haikyuu marked this conversation as resolved.
Show resolved Hide resolved
if (!result)
continue
const sourcePos = await getOriginalPos(transformResult.map as any as RawSourceMap | undefined, frame)
const fetchResult = ctx.vitenode.fetchCache.get(frame.file)?.result
const map = fetchResult?.map || ssrTransformResult?.map
const sourcePos = await getOriginalPos(map as any as RawSourceMap | undefined, frame)
if (sourcePos)
frame.sourcePos = sourcePos
}
Expand Down