Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Istanbul Coverage only for changed Files #2385

Merged
merged 16 commits into from Jan 8, 2023
Merged

feat: Istanbul Coverage only for changed Files #2385

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3310b8e
feat: Istanbul Coverage only for changed Files
g4rry420 Nov 28, 2022
3ccce65
chore: resolved conflicts
g4rry420 Nov 28, 2022
25c2793
chore: latest pnpm install changes
g4rry420 Nov 28, 2022
441da32
chore: resolved conflicts
g4rry420 Dec 11, 2022
f93eae4
chore: removed previous changes related to ctx.changedTests and watch…
g4rry420 Dec 11, 2022
7e48be5
chore: cleanOnReRun=true and all=false if watch mode is enabled
g4rry420 Dec 12, 2022
63d5136
chore: deleted example
g4rry420 Dec 12, 2022
6207a16
chore: updated pnpm-lock file after deleting example
g4rry420 Dec 12, 2022
d4aa7d3
chore: change default value for clearOnReRun=true, since watch= true …
g4rry420 Dec 13, 2022
3ea8839
Merge branch 'main' into issue_2316
g4rry420 Dec 13, 2022
77f6e1a
chore: resolved conflicts in pnpm-lock.yaml
g4rry420 Dec 30, 2022
3e23782
chore: Updated pnpm-lock.yaml file
g4rry420 Dec 30, 2022
9583cc0
Merge branch 'main' into issue_2316
g4rry420 Dec 31, 2022
4059d5e
Merge branch 'main' into issue_2316
g4rry420 Jan 6, 2023
efa61e0
chore: Update pnpm-lock.yaml
g4rry420 Jan 6, 2023
c110a85
chore: Update pnpm.yaml file as per in main branch
g4rry420 Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/vitest/src/defaults.ts
View file
Open in desktop
Expand Up @@ -25,6 +25,7 @@ const defaultCoverageExcludes = [
]

const coverageConfigDefaults = {
all: false,
provider: 'c8',
enabled: false,
clean: true,
Expand Down
5 changes: 5 additions & 0 deletions packages/vitest/src/node/config.ts
View file
Open in desktop
Expand Up @@ -92,6 +92,11 @@ export function resolveConfig(
mode,
} as ResolvedConfig

if (resolved.watch) {
resolved.coverage.cleanOnRerun = true
resolved.coverage.all = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this override user's configurations, or simply set default values?

I'm not sure if we should override the values, as users are then unable to configure these at all in watch mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does overrides the user config, I have modified the changed, after new commits. Thanks for pointing these out.

}

if (viteConfig.base !== '/')
resolved.base = viteConfig.base

Expand Down
107 changes: 29 additions & 78 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.