Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: puppeteer in the browser (headless mode) #2517

Closed
wants to merge 6 commits into from

Conversation

Aslemammad
Copy link
Member

@Aslemammad Aslemammad commented Dec 16, 2022

After a long time, this PR tries to add puppeteer as a headless browser to the web-runner.

  • Puppeteer
  • Headless mode (CI)
  • Reviewed by @JessicaSachs @userquin as the main browser contributors
  • Run mode does not work for vitest browser, fix it

@Aslemammad Aslemammad marked this pull request as draft December 16, 2022 11:32
@JessicaSachs
Copy link
Contributor

@Aslemammad whenever you're ready for me to look at this, add some steps to test and I'll play with it. 😄

@userquin
Copy link
Member

userquin commented Dec 23, 2022

Once build Vitest, you can run browser tests using one of the folllowing commands (change to test/browser folder):

  • pnpm vitest --browser --puppeteer
  • pnpm vitest --browser --puppeteer --headless
  • pnpm vitest run --browser --puppeteer
  • pnpm vitest run --browser --puppeteer --headless

@Aslemammad
Copy link
Member Author

@userquin @antfu I'd like to see what is remaining for this PR and what should be done, so I'd work on it! Let me know.

@christian-bromann
Copy link
Contributor

Would the Vitest team be interested in a WebdriverIO integration as an alternative that uses WebDriver as automation standard?

@Aslemammad
Copy link
Member Author

@christian-bromann Sure, we can discuss it! The reason why I started using puppeteer, is the easy steps that it needed for the integration! And it was straightforward. We can reconsider. Let me know in the Vitest official discord or even My DMs.

@Aslemammad
Copy link
Member Author

Let's close this in favor of #2999

@Aslemammad Aslemammad closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants