Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): allow overrides reporter via cli option #2573

Merged
merged 5 commits into from Jan 1, 2023
Merged

fix(cli): allow overrides reporter via cli option #2573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ba091d1
fix(cli): allow overrides reporter via cli option
mysteryven Dec 28, 2022
e9e13b1
refactor: use ??
mysteryven Dec 29, 2022
6950444
refactor: remove unused codes
mysteryven Dec 29, 2022
20f0c47
chore: add timeout
mysteryven Dec 30, 2022
76ceaff
chore: change test
mysteryven Dec 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/vitest/src/node/config.ts
View file
Open in desktop
Expand Up @@ -198,11 +198,9 @@ export function resolveConfig(
resolved.related = toArray(options.related).map(file => resolve(resolved.root, file))

if (mode !== 'benchmark') {
resolved.reporters = Array.from(new Set([
...toArray(resolved.reporters),
// @ts-expect-error from CLI
...toArray(resolved.reporter),
])).filter(Boolean)
// @ts-expect-error from CLI
const reporters = resolved.reporter ?? resolved.reporters
resolved.reporters = Array.from(new Set(toArray(reporters))).filter(Boolean)
}

if (!resolved.reporters.length)
Expand Down
6 changes: 6 additions & 0 deletions test/reporters/tests/custom-reporter.spec.ts
View file
Open in desktop
Expand Up @@ -71,4 +71,10 @@ describe.concurrent('custom reporters', () => {
const stdout = await runWithRetry('--config', 'without-custom-reporter.vitest.config.ts', '--reporter', customJSReporterPath)
expect(stdout).includes('hello from custom reporter')
}, TIMEOUT)

test('overrides reporters by given a CLI argument --reporter works', async () => {
const stdout = await runWithRetry('--config', 'deps-reporter.vitest.config.ts', '--reporter', customJSReporterPath)
expect(stdout).not.includes('hello from package reporter')
expect(stdout).includes('hello from custom reporter')
}, TIMEOUT)
})