test: add typing tests for coverage #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sheremet-va any ideas why the Windows CI fails? Seems that it's unable to resolve typings of |
AriPerkkio
commented
Jan 13, 2023
AriPerkkio
force-pushed
the
test/type-tests-coverage
branch
2 times, most recently
from
849eb97
to
b60b12d
Compare
This should fix it: #2660 |
This was referenced Jan 16, 2023
AriPerkkio
force-pushed
the
test/type-tests-coverage
branch
from
b60b12d
to
ebc59b9
Compare
|
Windows CI fixed by |
sheremet-va
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typings tests for coverage options. I'm building another coverage related feature, and run into so many internal typing errors that I decided to refactor internal typings quite much. Before refactoring the typings, some tests should be in place.