feat(ui): add html coverage #3071
Conversation
|
upps: snapshots changed, should revert changes? |
It's fine. Your UI tests failed, what is going on there? |
I have no idea, test are passing on my local. |
# Conflicts: # pnpm-lock.yaml
|
LICENSE.md file gets updated |
|
@userquin can you rebase this last time and remove the LICENSE file? |
# Conflicts: # packages/ui/client/components/Suites.vue # packages/ui/node/index.ts
|
Seems like tests are failing. Also is it possible to remove changes to lockfile? I don't think you've added any packages or changed their versions to change it, it only causes conflicts. I recommend using |
# Conflicts: # pnpm-lock.yaml
| "peerDependencies": { | ||
| "vitest": ">=0.30.1 <1" | ||
| }, |
There was a problem hiding this comment.
Note that this makes the feature a breaking change - which is OK, but should be indicated in release notes. Maybe even in the PR description here.
|
Moving hint to the right, the hint should be present in the same place coverage button, also adding
|
The iframe will be shown as it is, dark mode will not change the styles: IIRC we cannot change the styles from outside, maybe I can try to intercept the
index.htmladding a new css.There is a problem initializing the UIPlugin, it seems the coverage configuration isn't available, I've configured the defaults (Vitest context initilize logic to resolve
reportsDirectory).EDIT: to test html coverage, run
pnpm vitest --open --ui --coverage.enabled=truefromtest/corefolder and once Vitest has been built.https://streamable.com/whue6m
supersedes #2364
closes #2336