Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite-node): allow returning id not wrapped in promise #3312

Merged
merged 2 commits into from May 7, 2023
Merged

fix(vite-node): allow returning id not wrapped in promise #3312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07ec566
fix(vite-node): allow returning id not wrapped in promise
danielroe May 6, 2023
80daf71
chore: add more falsy types and add `Awaitable`
danielroe May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vite-node/src/types.ts
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@ import type { ModuleCacheMap, ViteNodeRunner } from './client'

export type Nullable<T> = T | null | undefined
export type Arrayable<T> = T | Array<T>
export type Awaitable<T> = T | PromiseLike<T>

export interface DepsHandlingOptions {
external?: (string | RegExp)[]
Expand Down Expand Up @@ -41,7 +42,7 @@ export type HotContext = Omit<ViteHotContext, 'acceptDeps' | 'decline'>

export type FetchFunction = (id: string) => Promise<FetchResult>

export type ResolveIdFunction = (id: string, importer?: string) => Promise<ViteNodeResolveId | null>
export type ResolveIdFunction = (id: string, importer?: string) => Awaitable<ViteNodeResolveId | null | undefined | void>

export type CreateHotContextFunction = (runner: ViteNodeRunner, url: string) => HotContext

Expand Down