Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite-node): don't remove sourcemap string in source code (#2918) #3379

Merged
merged 7 commits into from May 25, 2023
Merged

fix(vite-node): don't remove sourcemap string in source code (#2918) #3379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d4c641
fix(vite-node): don't remove sourcemap string in code (#2918)
rxliuli May 16, 2023
8e7698b
test: add sourcemap unit test
rxliuli May 17, 2023
bdb5b22
Merge branch 'main' into fix-2918
rxliuli May 17, 2023
8d73889
Merge branch 'main' into fix-2918
rxliuli May 22, 2023
5e19ec4
Merge branch 'main' into fix-2918
sheremet-va May 24, 2023
d6ec9aa
fix: update regex for match sourcemap
rxliuli May 25, 2023
919a099
Merge branch 'fix-2918' of https://github.com/rxliuli/vitest into fix…
rxliuli May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions examples/basic/test/sourcemap.test.ts
View file
Open in desktop
@@ -0,0 +1,7 @@
import { expect, it } from 'vitest'

it('should have sourcemaps', () => {
expect('\n//# sourceMappingURL=data:application/json;charset=utf-8;base64,').toBeTruthy()
expect('\n//# sourceMappingURL=data:application/json;charset=utf-8;base64,').toBeTruthy()
expect('\n//# sourceMappingURL=data:application/json;charset=utf-8;base64,').toBeTruthy()
})
3 changes: 2 additions & 1 deletion packages/vite-node/src/source-map.ts
View file
Open in desktop
Expand Up @@ -41,7 +41,8 @@ export function withInlineSourcemap(result: TransformResult, options: {
})

// to reduce the payload size, we only inline vite node source map, because it's also the only one we use
const OTHER_SOURCE_MAP_REGEXP = new RegExp(`//# ${SOURCEMAPPING_URL}=data:application/json[^,]+base64,(.+)`, 'g')
// const OTHER_SOURCE_MAP_REGEXP = new RegExp(`//# ${SOURCEMAPPING_URL}=data:application/json[^,]+base64,(.+)`, 'g')
const OTHER_SOURCE_MAP_REGEXP = /(?<!['"`])\/\/# ${SOURCEMAPPING_URL}=data:application\/json[^,]+base64,(.+?)(?!\w)/g
while (OTHER_SOURCE_MAP_REGEXP.test(code))
code = code.replace(OTHER_SOURCE_MAP_REGEXP, '')

Expand Down