Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix errors caused by commonjs export circular references #3570

Merged
merged 2 commits into from Jun 15, 2023
Merged

fix: Fix errors caused by commonjs export circular references #3570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e2303b
Fix errors caused by commonjs export circular references, ref: https:…
rxliuli Jun 14, 2023
0c547a1
Merge branch 'main' of https://github.com/vitest-dev/vitest into fix-…
rxliuli Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite-node/src/client.ts
View file
Open in desktop
Expand Up @@ -330,7 +330,7 @@ export class ViteNodeRunner {
set: (_, p, value) => {
// treat "module.exports =" the same as "exports.default =" to not have nested "default.default",
// so "exports.default" becomes the actual module
if (p === 'default' && this.shouldInterop(modulePath, { default: value })) {
if (p === 'default' && this.shouldInterop(modulePath, { default: value }) && cjsExports !== value) {
exportAll(cjsExports, value)
exports.default = value
return true
Expand Down