Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update to the correct test #3643

Merged
merged 6 commits into from Jun 26, 2023

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jun 21, 2023

Related PR: #3266

I think I know what causes Ci to always fail. default reporter also prints all the test logs when it runs. However, as the test task is updated, some tests will no longer be printed out.

So in runVitestCli, the run logs of all tests will be stored in stdout, so b1 test may exist due to different machines and different run times, etc. Now I've added to them to make sure they are not included in the final test log.

And this change is consistent with the intent of the original test.

@stackblitz
Copy link

stackblitz bot commented Jun 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Dunqing Dunqing marked this pull request as draft June 21, 2023 15:14
@Dunqing Dunqing marked this pull request as ready for review June 22, 2023 09:39
@Dunqing Dunqing changed the title test: avoid test failed test: update to the correct test Jun 22, 2023
Copy link
Member

@AriPerkkio AriPerkkio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also increase the chaiConfig.truncateThreshold of test/reporters/vitest.config.ts as the current error messages do not show what the actual output was:

AssertionError: expected '? Input filename pattern › b✔ Input f…' to not include 'b1 test'

Example:

chaiConfig: {
truncateThreshold: 9999,
},

@Dunqing
Copy link
Member Author

Dunqing commented Jun 25, 2023

Maybe also increase the chaiConfig.truncateThreshold of test/reporters/vitest.config.ts as the current error messages do not show what the actual output was:


AssertionError: expected '? Input filename pattern › b✔ Input f…' to not include 'b1 test'

Example:

chaiConfig: {
truncateThreshold: 9999,
},

Wow, Thank you, I regret learning about it too late.

@sheremet-va
Copy link
Member

Thank you! Let's hope this is enough

@sheremet-va sheremet-va merged commit 6d26b8c into vitest-dev:main Jun 26, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants