fix: isolate workers between envs and workspaces #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
AriPerkkio
commented
Jul 2, 2023
AriPerkkio
force-pushed
the
fix/isolate-environments
branch
3 times, most recently
from
47fc512
to
d417344
Compare
AriPerkkio
force-pushed
the
fix/isolate-environments
branch
from
d417344
to
82ea94a
Compare
AriPerkkio
commented
Jul 6, 2023
Comment on lines
+167
to
+170
| // Once all tasks are running or finished, recycle worker for isolation. | ||
| // On-going workers will run in the previous environment. | ||
| await new Promise<void>(resolve => pool.queueSize === 0 ? resolve() : pool.once('drain', resolve)) | ||
| await pool.recycleWorkers() |
There was a problem hiding this comment.
To summarize this:
- Pool's queue is filled with tasks that have same options (env, workspace)
- When pool takes the last task from queue, we tell pool to recycle all workers and fill queue with tasks that have new options
- The earlier tasks will run and recycle once they finish
- New tasks in the queue will use fresh workers
This guarantees that tasks with different options are run parallel.
sheremet-va
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pool.recycleWorkers()method tinylibs/tinypool#63When running files with threads enabled, make sure workers are recycled when ever environment options or workspace changes.
Also noticed that when running tests of workspace through
startVitestNode API, the logger does not include project names in log entries.