fix(vitest): shouldn't open the browser by default #4094
Conversation
|
|
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
| @@ -57,7 +57,7 @@ export async function VitestPlugin(options: UserConfig = {}, ctx = new Vitest('t | |||
|
|
|||
| ;(options as ResolvedConfig).defines = defines | |||
|
|
|||
| let open: string | boolean | undefined | |||
| let open: string | boolean | undefined = false | |||
There was a problem hiding this comment.
This doesn't actually fix the issue. Server still starts on the same port. What is needed here is to update resolveApiConfig method - it should treat optimizer.web.enabled and optimizer.ssr.enabled like --api flag. They are enabled by default, by the way, so they need to be explicitly set to false for us to not start a server.
This change hovewer should also be included in the fix. We only want to open a server when ui is enabled
There was a problem hiding this comment.
Okay, I've changed it, I'm not sure I got your point entirely
There was a problem hiding this comment.
Mostly yes, but I got a step further: #4095
What do you think?
There was a problem hiding this comment.
Mostly yes, but I got a step further: #4095
What do you think?
I think good!
Description
fix: #4052
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.