New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!(spy): align mocking related typings with jest #4784
Open
hi-ogawa
wants to merge
18
commits into
vitest-dev:main
Choose a base branch
from
hi-ogawa:feat-breaking-fn-mock-typing
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
e2d6312
fix!(spy): align vi.fn and vi.Mock typings to jest
hi-ogawa c5781fe
fix: put back `any` for starter
hi-ogawa 8a13a22
chore: lint
hi-ogawa a87d320
chore: back to "unknown"
hi-ogawa a0e8876
Merge branch 'main' into feat-breaking-fn-mock-typing
hi-ogawa f79f1c8
chore: revert lock
hi-ogawa 5efee95
chore: more any type
hi-ogawa ba54044
Merge branch 'main' into feat-breaking-fn-mock-typing
hi-ogawa c17bac0
Merge branch 'main' into feat-breaking-fn-mock-typing
hi-ogawa 4f50db5
Merge branch 'main' into feat-breaking-fn-mock-typing
hi-ogawa a3bdb7a
fix: fix types
hi-ogawa e034a05
test: fix and add
hi-ogawa eb1c442
fix: give up "ts/method-signature-style"
hi-ogawa d0903b6
chore: comment
hi-ogawa fef7e5f
chore: cleanup
hi-ogawa cb777f1
chore: cleanup
hi-ogawa 2363d57
Merge branch 'main' into feat-breaking-fn-mock-typing
hi-ogawa 7b59e10
feat: replace `any` with `unknown` for default types
hi-ogawa File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the latter one to follow Jest for now, but I think going with the former should be totally fine too.
Jest one is technically type unsafe and the assignment example I wrote here can be easily rewritten by:
Or in a more realistic scenario, it would probably look like: