Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add default for fakeTimers.toFake #5197

Merged
merged 5 commits into from Mar 26, 2024

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 14, 2024

Description

Not sure if this is a right way, but I patched @types/sinonjs__fake-timers to update jsdoc. I guess it'll work since it's bundled, but please let me know if there is a better approach to this.

It's expected to appear like this:

screenshot

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 037a3a2
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6602d84af40c080008c4f4c9
😎 Deploy Preview https://deploy-preview-5197--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa hi-ogawa changed the title Docs timers to fake docs: add default for fakeTimers.toFake Feb 14, 2024
@hi-ogawa hi-ogawa marked this pull request as ready for review February 14, 2024 02:31
docs/api/vi.md Outdated Show resolved Hide resolved
Co-authored-by: Anjorin Damilare <damilareanjorin1@gmail.com>
@sheremet-va sheremet-va merged commit 2e8e05e into vitest-dev:main Mar 26, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants