Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update playwright 1.42.0 #5320

Closed
wants to merge 1 commit into from

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 1, 2024

Description

It seems CI is broken again on playwright v1.42.0 release. I manually bumped them again (same as last time 1.41.0 #4988)

pnpm update -r --latest playwright playwright-core @playwright/test

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

```sh
pnpm update -r --latest playwright playwright-core @playwright/test
```
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit 39675a9
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65e12773ba4e4d00086206c7
😎 Deploy Preview https://deploy-preview-5320--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hi-ogawa
Copy link
Contributor Author

hi-ogawa commented Mar 1, 2024

I found the culprit and fixed in

Manual bump should not be necessary and we can let renovate do it automatically.

@hi-ogawa hi-ogawa closed this Mar 1, 2024
@hi-ogawa hi-ogawa deleted the chore-playwright-1.42.0 branch March 1, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant