New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove the empty suite from the runner #5435
Merged
sheremet-va
merged 16 commits into
vitest-dev:main
from
sheremet-va:feat/remove-inlined-suite
May 6, 2024
Merged
feat!: remove the empty suite from the runner #5435
sheremet-va
merged 16 commits into
vitest-dev:main
from
sheremet-va:feat/remove-inlined-suite
May 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
6 tasks
AriPerkkio
reviewed
Mar 31, 2024
sheremet-va
force-pushed
the
feat/remove-inlined-suite
branch
from
April 2, 2024 09:49
a202e9d
to
4e9931e
Compare
sheremet-va
force-pushed
the
feat/remove-inlined-suite
branch
from
May 6, 2024 09:42
049a1de
to
5ba1bbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the default empty suite that was reported with all tasks and led to a few confusing bugs:
file
property they can fallback to if they need the file informationexpect.getState().testPath
is always defined nowexpect.getState().currentTestName
doesn't have the file anymoreFixes #4045
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.