Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove the empty suite from the runner #5435

Merged
merged 16 commits into from May 6, 2024

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Mar 26, 2024

Description

This PR removes the default empty suite that was reported with all tasks and led to a few confusing bugs:

  • It always existed even if the test was not inside any suites
    • Because of this test names had an empty string at the start
    • Custom reporters had to check for the id/name of the internal suite to correctly report results
  • All tasks now have a file property they can fallback to if they need the file information
  • expect.getState().testPath is always defined now
  • expect.getState().currentTestName doesn't have the file anymore

Fixes #4045

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va added this to the 2.0.0 milestone Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 5ba1bbb
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6638a604ca83a90008a7c4ea

@sheremet-va sheremet-va merged commit dbbbe43 into vitest-dev:main May 6, 2024
18 of 19 checks passed
@sheremet-va sheremet-va deleted the feat/remove-inlined-suite branch May 6, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getTaskFullName() includes leading space, breaking testNamePattern
2 participants