Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: enable coverage.ignoreEmptyLines by default #5543

Conversation

AriPerkkio
Copy link
Member

Description

Changes default value of coverage.ignoreEmptyLines to true. This change will have major impact on users' code coverage reports. It is likely that projects using coverage thresholds need to adjust those values after this.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio added this to the 2.0.0 milestone Apr 14, 2024
Copy link

netlify bot commented Apr 14, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit a389ce8
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/6639aeed79e67500085462ef
😎 Deploy Preview https://deploy-preview-5543--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio force-pushed the feat/coverage-enable-ignore-empty-lines branch from c04d9af to 6c79e63 Compare April 14, 2024 17:20
@sheremet-va
Copy link
Member

Can you resolve the conflict, please?

@AriPerkkio AriPerkkio force-pushed the feat/coverage-enable-ignore-empty-lines branch from 6c79e63 to a389ce8 Compare May 7, 2024 04:32
@sheremet-va sheremet-va merged commit 3199494 into vitest-dev:main May 7, 2024
18 of 19 checks passed
@AriPerkkio AriPerkkio deleted the feat/coverage-enable-ignore-empty-lines branch May 7, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants