Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: web support (browser as an environment) #891

Closed
wants to merge 32 commits into from

Conversation

Aslemammad
Copy link
Member

@Aslemammad Aslemammad commented Mar 3, 2022

It is surely ready for review!

@netlify
Copy link

netlify bot commented Mar 3, 2022

Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit e4621af
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62495eab22850d00085625c0
😎 Deploy Preview https://deploy-preview-891--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Aslemammad Aslemammad added the wip label Mar 3, 2022
@antfu antfu marked this pull request as draft March 3, 2022 11:53
@Aslemammad
Copy link
Member Author

Aslemammad commented Mar 3, 2022

Hopefully we can get an iframe with the @vitest/ui in this integration + pre bundling!

@userquin
Copy link
Member

userquin commented Mar 3, 2022

@Aslemammad @patak-dev about using an iframe:

@Aslemammad Aslemammad marked this pull request as ready for review March 13, 2022 05:35
@Aslemammad Aslemammad requested a review from antfu March 13, 2022 07:51
@Aslemammad
Copy link
Member Author

pnpm -w run dev
pnpm -w run web:dev
cd test/web
pnpm vitest --web

@edimitchel
Copy link
Member

edimitchel commented Mar 15, 2022

to test the ui on web you will need:
* pnpm run build && pnpm run web:build from root
* copy packages/ui/dist/client/**, create packages/web/dist/__vitest__ folder and paste the content inside
* cd test/web && vitest --web

Small updates

@edimitchel edimitchel added the feat: ui Vitest UI label Mar 15, 2022
@antfu antfu removed the wip label Mar 16, 2022
@antfu
Copy link
Member

antfu commented Mar 16, 2022

Thanks for the PR! I will have a closer look on the weekend. Before that, it would be great if you could help resolve the conflicts!

@Aslemammad
Copy link
Member Author

I am resolving the conflicts!

@Aslemammad
Copy link
Member Author

resolved!

@edimitchel
Copy link
Member

Let now try that on StackBlitz and let get webception 🤯 !

@userquin
Copy link
Member

Let now try that on StackBlitz and let get webception 🤯 !

we need to invert the iframe, the web should be isolated on it instead adding ui on the iframe

@edimitchel
Copy link
Member

Actually I tried it and it works like a charm!
But I got some issue with Snapshots.

@antfu antfu added this to the Next milestone May 3, 2022
@Manish3323
Copy link

This is a great feature, looking forward to use this feature..

@antfu antfu mentioned this pull request May 13, 2022
7 tasks
@antfu
Copy link
Member

antfu commented May 14, 2022

Continues on #1302

@antfu antfu marked this pull request as draft May 14, 2022 08:42
@antfu antfu added on hold and removed feat: ui Vitest UI labels May 14, 2022
@sheremet-va
Copy link
Member

Closed in favour of #1302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants