test: fix e2e #310
Closed
test: fix e2e #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AriPerkkio
reviewed
Mar 20, 2024
| }) | ||
|
|
||
| test('imba', async ({ launch }) => { | ||
| await execa('npm', ['i'], { cwd: './samples/imba' }) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, I think that's the same issue.
There was a problem hiding this comment.
Hmm, technically if samples/imba installed its own Vitest, then it's not testing against ecosystem-ci's Vitest.
There was a problem hiding this comment.
Superseded by
I'll also setup a wrapper script for ecosystem-ci, so we can tweak things while keeping the same script on ecosystem-ci repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm iwas missing forsamples/imbae2e. I also replaced.clickwithexpect(...).isVisible()since it looks like unnecessary click is causing UI to glitch sometimes.