Avoid accidentally changing the logical size when changing user scale due to rounding errors #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happened due to rounding errors in the conversion to and from integers. We can detect this by doing the same computation, and treating the resize as a noop if it does happen. This prevents the logical size from slowly drifting when changing the user scale many times in a row.
robbert-vdh
commented
Dec 30, 2023
Comment on lines
+218
to
221
| // TODO: Without this `WindowEvent::GeoChanged` isn't emitted for every element, even | ||
| // though this same function is also called in the | ||
| // `baseview::WindowEvent::Resized` event handler. Why? | ||
| cx.set_scale_factor(self.window_scale_factor * self.current_user_scale_factor); |
There was a problem hiding this comment.
This is the part I don't get. This call shouldn't be necessary since the event handler calls the same function with the same values, but without it not all GeometryChanged events are fired. Specifically, the event is not fired for Models, like in the user_scale example.
There was a problem hiding this comment.
Something similar happens when changing just the window size (and this call doesn't help there). GeometryChanged isn't called for Models when changing just the window size.
|
I'll probably end up changing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened due to rounding errors in the conversion to and from integers. We can detect this by doing the same computation, and treating the resize as a noop if it does happen. This prevents the logical size from slowly drifting when changing the user scale many times in a row.