Update default values in types (globby, fast-glob) #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We are setting both
onlyFilesandexxpandDirectoriesoptions tofalsehere as they are set totrueby default in globby and fast-glob.In VSCode the autocomplete currently shows with
@default: truetext so I really assumed that it is really set to true before looking at source code.This PR changes the
@defaultflag tofalseso it's inline with this rollup-plugin-copy options.Not sure if there is a better way of changing intellisense
@defaultfrom 'true' to 'false'. I've copied the type declaraitions from both globby and fast-glob and just changed the default values.