[CI/Build] Platform agnostic wheel #4773
Open
+109
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomeras91
commented
May 12, 2024
There was a problem hiding this comment.
Curious to hear your thoughts.. currently the PR just enables building of the platform agnostic wheel. What do you think about adding this build to publish.yml so it will be build on every release?
| @@ -2,5 +2,4 @@ | |||
| -r requirements-common.txt | |||
|
|
|||
| # Dependencies for x86_64 CPUs | |||
| torch == 2.3.0+cpu | |||
| triton >= 2.2.0 # FIXME(woosuk): This is a hack to avoid import error. | |||
There was a problem hiding this comment.
Dealt with triton import errors in code
|
Interestingly Triton recently supported macOS with Apple Silicon: triton-lang/triton#3443 |
Yep. But AFAIU they still release wheels only for Linux so it can't be pip installed directly from pypi. I guess building from source is the only option to get triton installed on mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables build of a platform-agnostic wheel which is installable also on macos. The idea is to improve the dev-experience for creating projects that import and use vLLM.
Important: This wheel does not enable running of vllm on mac, but does allow to import it.
The PR doesn't entirely fix issues #212, #695, #1397, #1921, but it's a step forward.