feat: improve automatic format detection #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more patterns to automatic format detector, pick a format that produces maximum date fixes #103
vlsi
force-pushed
the
date_format_detect
branch
from
2340c61
to
cbec464
Compare
|
will do the review over the weekend. @elkrieg please also have a look and share your thoughts |
Pitterling
reviewed
Aug 20, 2017
| DateTimeFormatter best = null; | ||
| LocalDate bestDate = null; | ||
| for (DateTimeFormatter format : DATE_FORMATS) { | ||
| try { |
There was a problem hiding this comment.
logging would be great .. log.Trace "found valid .."
Pitterling
reviewed
Aug 20, 2017
| try { | ||
| LocalDate nextDate = LocalDate.parse(dateString, format); | ||
| if (bestDate == null || nextDate.compareTo(bestDate) >= 0) { | ||
| bestDate = nextDate; |
There was a problem hiding this comment.
also here .. log.trace "found better date"
Pitterling
reviewed
Aug 20, 2017
There was a problem hiding this comment.
in general its ok, but it only works with the assumption that you look only to recent files. What if i look the older files for comparison reason ..
We could also offer the possible formats in an optional box ?? Or provide 2 options a) automatic detection choose best .. and b) automatic detection - ask ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more patterns to automatic format detector, pick a format that produces maximum date
fixes #103