Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .npmignore #592

Merged
merged 2 commits into from May 11, 2023
Merged

Update .npmignore #592

merged 2 commits into from May 11, 2023

Conversation

H1Gdev
Copy link
Collaborator

@H1Gdev H1Gdev commented May 10, 2023

from

npm pack --dry-run
npm notice
npm notice  frisby@2.1.3
npm notice === Tarball Contents ===
npm notice 4.9kB  __tests__/expects_json_path_spec.js
npm notice 6.2kB  __tests__/expects_json_spec.js
npm notice 6.0kB  __tests__/expects_jsonTypes_spec.js
npm notice 603B   __tests__/expects_not_spec.js
npm notice 3.2kB  __tests__/expects_spec.js
npm notice 1.3kB  __tests__/file_upload_spec.js
npm notice 4.2kB  __tests__/fixtures/frisby-logo.png
npm notice 5.6kB  __tests__/fixtures/http_mocks.js
npm notice 12.1kB __tests__/frisby_spec.js
npm notice 1.2kB  __tests__/nested_spec.js
npm notice 513B   .eslintrc.json
npm notice 451B   .github/workflows/ci.yml
npm notice 5.3kB  README.md
npm notice 1.0kB  package.json
npm notice 3.5kB  src/frisby.js
npm notice 4.3kB  src/frisby/expects.js
npm notice 406B   src/frisby/response.js
npm notice 12.0kB src/frisby/spec.js
npm notice 1.8kB  src/frisby/utils.js
npm notice === Tarball Details ===
npm notice name:          frisby
npm notice version:       2.1.3
npm notice filename:      frisby-2.1.3.tgz
npm notice package size:  19.7 kB
npm notice unpacked size: 74.5 kB
npm notice shasum:        9aa991139adece8dbc05237538405015a8e06651
npm notice integrity:     sha512-e878KEF5kAxWT[...]EJyxm9yERh8ow==
npm notice total files:   19
npm notice
frisby-2.1.3.tgz

to

npm pack --dry-run
npm notice
npm notice  frisby@2.1.3
npm notice === Tarball Contents ===
npm notice 5.3kB  README.md
npm notice 1.0kB  package.json
npm notice 3.5kB  src/frisby.js
npm notice 4.3kB  src/frisby/expects.js
npm notice 406B   src/frisby/response.js
npm notice 12.0kB src/frisby/spec.js
npm notice 1.8kB  src/frisby/utils.js
npm notice === Tarball Details ===
npm notice name:          frisby
npm notice version:       2.1.3
npm notice filename:      frisby-2.1.3.tgz
npm notice package size:  8.4 kB
npm notice unpacked size: 28.3 kB
npm notice shasum:        8a78408d789b7e011078f4a4bdbf6c1b414a08a3
npm notice integrity:     sha512-ES4MJq9B0gTK+[...]JDFkUUxH2z3qw==
npm notice total files:   7
npm notice
frisby-2.1.3.tgz

@koooge
Copy link
Collaborator

koooge commented May 10, 2023

Nice find. How about writing "files" in package.json instead of .npmignore?

  "files": [
    "src/"
  ],

@H1Gdev
Copy link
Collaborator Author

H1Gdev commented May 10, 2023

@koooge
.npmignore file existed, so I updated it !!

Is there any benefit of using files field ?
I didn't find clear benefit...

Copy link
Collaborator

@koooge koooge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koooge
Copy link
Collaborator

koooge commented May 11, 2023

@koooge .npmignore file existed, so I updated it !!

Is there any benefit of using files field ? I didn't find clear benefit...

It is the difference between whitelist and blacklist. Honestly, almost the same but it would be more clear. Thanks!

@H1Gdev H1Gdev merged commit b81b492 into vlucas:master May 11, 2023
4 checks passed
@H1Gdev H1Gdev deleted the npmignore branch May 11, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants