Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UT runtime #1339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve UT runtime #1339

wants to merge 1 commit into from

Conversation

aaha97
Copy link
Contributor

@aaha97 aaha97 commented Dec 7, 2023

Run UTs in a single container, avoid running docker run with each make target

@aaha97 aaha97 self-assigned this Dec 7, 2023
@Dhivyaaj
Copy link

Dhivyaaj commented Dec 7, 2023

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 7, 2023

build ako

@akshayhavile
Copy link
Contributor

@aaha97 UT time seems to be improved by 20 min. Can we do one more experiment... can we check impact of increasing value of j to more than 1 in make -j 1 k8stest... command?

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

build ako

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

skip jira-id-check

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

build ako

2 similar comments
@aaha97
Copy link
Contributor Author

aaha97 commented Dec 13, 2023

build ako

@akshayhavile
Copy link
Contributor

build ako

@Dhivyaaj
Copy link

No JIRA Ids found for the PR. Jira id is mandatory to update fix version in jira. Please update respective Jira id in PR title or commit message if the PR is intented for default branches of repo. For mandatory exemptions, comment trigger phrase 'skip jira-id-check' in PR. For manual trigger, comment trigger phrase 'run jira-id-check' in PR.

@aaha97
Copy link
Contributor Author

aaha97 commented Dec 14, 2023

build ako

1 similar comment
@aaha97
Copy link
Contributor Author

aaha97 commented Dec 14, 2023

build ako

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arihantg arihantg Awaiting requested review from arihantg

@akshayhavile akshayhavile Awaiting requested review from akshayhavile

@apalsule apalsule Awaiting requested review from apalsule

@pkoshtavmware pkoshtavmware Awaiting requested review from pkoshtavmware

@saurabhvaidvmware saurabhvaidvmware Awaiting requested review from saurabhvaidvmware

@DixitAakash DixitAakash Awaiting requested review from DixitAakash

At least 2 approving reviews are required to merge this pull request.

Assignees

@aaha97 aaha97

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aaha97 @Dhivyaaj @akshayhavile @vmwclabot