Implement ODS runbook invocation resource #1020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
6210c98
to
fab5059
Compare
|
/test-all |
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
fab5059
to
38a032c
Compare
|
/test-all |
1 similar comment
|
/test-all |
ksamoray
force-pushed
the
ods-runbook-invocation
branch
3 times, most recently
from
4c403fb
to
c471bc0
Compare
ksamoray
force-pushed
the
ods-runbook-invocation
branch
4 times, most recently
from
dc73bfb
to
a73f745
Compare
annakhm
reviewed
Nov 16, 2023
| Schema: map[string]*schema.Schema{ | ||
| "nsx_id": getNsxIDSchema(), | ||
| "path": getPathSchema(), | ||
| // Due to a bug, invocations with a display_name specification fail, and when there's none set, NSX assigns |
There was a problem hiding this comment.
So the user can't specify display_name?
There was a problem hiding this comment.
For now, he can't. The runbook won't execute, it's a bug which they intend to fix obviously.
annakhm
reviewed
Nov 16, 2023
| }, | ||
| }, | ||
| }, | ||
| "runbook_path": { |
There was a problem hiding this comment.
Shouldn't this and below be defined as ForceNew?
annakhm
reviewed
Nov 16, 2023
| return nil | ||
| } | ||
|
|
||
| func resourceNsxtPolicyODSRunbookInvocationUpdate(d *schema.ResourceData, m interface{}) error { |
There was a problem hiding this comment.
If the user changes description, this will result in constant non-empty diff. Do tags/description have any value for this resource, perhaps we can remove them?
There was a problem hiding this comment.
Makes sense, if anyone ever needs them we can reevaluate how to handle these.
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
a73f745
to
31e0a22
Compare
|
/test-all |
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
31e0a22
to
9714003
Compare
ksamoray
force-pushed
the
ods-runbook-invocation
branch
2 times, most recently
from
1f7f731
to
f79fcee
Compare
|
/test-all |
ksamoray
force-pushed
the
ods-runbook-invocation
branch
2 times, most recently
from
3c78198
to
2e834f5
Compare
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
2e834f5
to
abb69c0
Compare
|
/test-all |
1 similar comment
|
/test-all |
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
abb69c0
to
24c6551
Compare
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
24c6551
to
d11f365
Compare
|
/test-all |
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
d11f365
to
5ccfd16
Compare
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
5ccfd16
to
2efb4ac
Compare
|
/test-all |
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
2efb4ac
to
2546fb7
Compare
Implement nsxt_policy_ods_pre_defined_runbook for ODS runbook framework. Signed-off-by: Kobi Samoray <ksamoray@vmware.com>
Signed-off-by: Kobi Samoray <ksamoray@vmware.com>
ksamoray
force-pushed
the
ods-runbook-invocation
branch
from
2546fb7
to
af8205f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.