feat: axios error handler, extract status from JS error (VF-000) #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trs
commented
Jun 29, 2022
| @@ -15,6 +15,7 @@ | |||
| "@types/http-errors": "^1.8.2", | |||
| "@voiceflow/logger": "1.6.1", | |||
| "@voiceflow/verror": "^1.1.0", | |||
| "axios": "0.27.2", | |||
There was a problem hiding this comment.
I'm wondering if we should just declare the type instead of including the entirety of axios.
trs
commented
Jun 29, 2022
| export const formatAxiosError: ExceptionFormatter<AxiosError> = (err) => { | ||
| return { | ||
| statusCode: err.response?.status, | ||
| name: 'AxiosError', |
There was a problem hiding this comment.
Because we're returning this to the client, we probably don't want to leak that errors are axios, gaxios, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements VF-000
Brief description. What is this change?
Adds an error format handler for axios errors.
Attempts to extract a status or statusCode from a JS error for formatting.