feat: add Segment AI requests events (NLU-775) #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuyak-vf
force-pushed
the
abuyak/KL-add-segment-AI-events/NLU-775
branch
from
3ae0975
to
8eedd82
Compare
abuyak-vf
force-pushed
the
abuyak/KL-add-segment-AI-events/NLU-775
branch
from
969830a
to
70f5d89
Compare
abuyak-vf
changed the title
DecathectZero
requested changes
Sep 7, 2023
There was a problem hiding this comment.
I think for all segment events, we should do this async, don't need to await it. It should run in the background to be non-blocking to the response.
If there is an error, we can .catch it and log it, but doesn't need to be part of the main interaction thread.
abuyak-vf
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
We're actually adding the analytics SDK to this repo, which will make this easier (https://voiceflow.atlassian.net/browse/PL-556) |
abuyak-vf
force-pushed
the
abuyak/KL-add-segment-AI-events/NLU-775
branch
from
81036e8
to
7dbdddd
Compare
abuyak-vf
force-pushed
the
abuyak/KL-add-segment-AI-events/NLU-775
branch
6 times, most recently
from
bfa8886
to
b61452f
Compare
abuyak-vf
force-pushed
the
abuyak/KL-add-segment-AI-events/NLU-775
branch
from
b61452f
to
218ed26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send Segment events during AI requests.
Brief description. What is this change?
Added segment calls to save events when calling AI models.
Setup information
Events:
Action types:
Deployment Notes
Related Ticket
NLU-775