feat: upgrade logger (PL-000) #692
Conversation
trs
force-pushed
the
trs/upgrade-logger/PL-000
branch
from
62b51f5
to
9259de1
Compare
|
|
I think https://github.com/pinojs/pino-http/blob/00b097bb54d87ec6ba27d92b4bd1612213e75def/logger.js#L133 |
There was a problem hiding this comment.
I think some changes might need to get made to the way promises are displayed. The only method with vars was actually pretty good:
https://github.com/voiceflow/logger/blob/3f4220c97ffa69351a3058d2000fa55547d90a91/lib/logger.ts#L78-L89
correct expectations:
I played around a lot with the logger, and I think this is the minimal risk one to solve the memory issue. This doesn't change anything with `backend-utils` and ensures the same logging behavior with `vars`: https://github.com/voiceflow/logger/blob/3f4220c97ffa69351a3058d2000fa55547d90a91/lib/logger.ts#L70-L89 added pino as a dev dependency PURELY for types, because `@voiceflow/backend-utils` uses a different version of pino and pino http. The longer term update is over here: #692 (review) Co-authored-by: Tyler Han <tylerhan97@gmail.com>
I played around a lot with the logger, and I think this is the minimal risk one to solve the memory issue. This doesn't change anything with `backend-utils` and ensures the same logging behavior with `vars`: https://github.com/voiceflow/logger/blob/3f4220c97ffa69351a3058d2000fa55547d90a91/lib/logger.ts#L70-L89 added pino as a dev dependency PURELY for types, because `@voiceflow/backend-utils` uses a different version of pino and pino http. The longer term update is over here: #692 (review) Co-authored-by: Tyler Han <tylerhan97@gmail.com>
Upgrade
@voiceflow/logger,@voiceflow/backend-utils