feat: add parsing of objects and array values (CV3-000) #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Brief description. What is this change? * Add Mattel and Redventures private clouds to KB allowed list ### Checklist - [x] Similar changes tested on other private clouds
Testing across the following areas. Works for KB base preview  Works for KB preview in step  Works for prototype KB step  Works for KB Query API <img width="856" alt="Screenshot 2024-03-07 at 5 31 56 PM" src="https://github.com/voiceflow/general-runtime/assets/5643574/cb2f7aec-11d1-423c-a898-2068ffad3cc4"> KB No Match Fallback With KB <img width="856" alt="Screenshot 2024-03-07 at 5 31 56 PM" src="https://github.com/voiceflow/general-runtime/assets/5643574/d4987677-9bf0-480b-a77f-0985a35a7c10"> KB No Match Fallback Without KB   Fetching Version Publishing  Co-authored-by: Tyler Han <tylerhan97@gmail.com> Co-authored-by: Tyler Stewart <tyler.stewart@voiceflow.com> Co-authored-by: Tyler Stewart <git@tylerstewart.ca> Co-authored-by: edison-voiceflow <edison.mukadah@voiceflow.com>
Carousel/card buttons created from a function can only open URLs, and should not send a request to the runtime. If a request is sent, we ensure it is of type `action`, so we do not execute the runtime. See: #678 Co-authored-by: Tyler Stewart <git@tylerstewart.ca>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements CV3-000
Brief description. What is this change?
Adds rudimentary support for passing object and array data into a function step. It achieves this by stringifying the object and array values in the runtime state before resolving diagram variables with this stringified value.
At the time of writing, function variable types have not been implemented.
Implementation details. How do you make this change?
Added
serializeVariables()to serialize runtime variable state.Called
serializeVariables()beforeutils.replaceVariables()to ensure that objects are serialized as JSON, rather than"[Object object]"Setup information
N/A
Deployment Notes
N/A
Related PRs
N/A
Checklist