(Diff) compare changes for CDS only in XdsClient #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
84ee546
to
31ae809
Compare
voidzcy
changed the title
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
31ae809
to
e49e860
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
d872bc2
to
dbface1
Compare
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
e49e860
to
9387c9b
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
dbface1
to
a8b5ad8
Compare
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
3 times, most recently
from
bc2f130
to
d1af988
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
bd55cb9
to
08d7b8c
Compare
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
d1af988
to
cfe5bdd
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
08d7b8c
to
4f555cf
Compare
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
2 times, most recently
from
4398806
to
bc8c4c6
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
ebe4b3e
to
3760201
Compare
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
bc8c4c6
to
50c9bb3
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
3760201
to
388e977
Compare
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
388e977
to
9de8847
Compare
…ore start This is already in the documentation in CallStreamObserver, but if the user gets here the error didn't provide an actionable next step. The message now provides more help of how they should have called the methods instead of feeling more like a brick wall.
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
50c9bb3
to
1264ef7
Compare
Currently `LoadStatsStore` is create by `LocalityStore` and `LoadReportClient` retrieves `LoadStatsStore` from `LocalityStore.getLoadStatsStore()`. But `LocalityStore` is create by EDS policy, whereas `LoadReportClient` and `LoadStatsStore` should be created by CDS (if not EDS-only), before `LocalityStore` is created. If `LoadReportClient` is embedded in `XdsClientImpl`, it need a `LoadStatsStore` which shouldn't be created by `LocalityStore`. Instead, `LoadStatsStore` should be create before `LocalityStore` is created, and be passed to `LocalityStore`'s constructor. A getter is not needed.
…r.Args (grpc#6455) Added new API on NameResolver.Args to access ScheduledExecutorService, which is wrapped transport executor.
voidzcy
force-pushed
the
impl/integrate_lds_rds_eds_in_xds_client
branch
from
5f83d44
to
dea0b46
Compare
This change implements EDS protocol in XdsClient, which requests for endpoint information for a given cluster for gRPC's load balancing usage. Note EDS is a quasi-incremental protocol, which means each response may contain only a subset of present resources. Absence of resources should be revealed by response timeout. Currently, timeout is not implemented, endpoint watchers will wait indefinitely if endpoints for the cluster interested in does not exist.
…roken. We should treat it as if had not received the message.
… not found in CDS response.
…esources to be able to ACK with last unsubscribed resource when all resources are unsubscribed.
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
1264ef7
to
1230951
Compare
…ntains invalid data.
voidzcy
force-pushed
the
impl/integrate_cds_in_xds_client
branch
from
49af78e
to
d325ccc
Compare
voidzcy
pushed a commit
that referenced
this pull request
Mar 25, 2020
Data race was detected internally when
ManagedChannelOrphanWrapper.shutdown() was called concurrently:
WARNING: ThreadSanitizer: data race (pid=5009)
Write of size 8 at 0x7fd2f7f37530 by thread T49:
#0 java.lang.ref.Reference.clear()V Reference.java:265
#1 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clearInternal()V ManagedChannelOrphanWrapper.java:118
#2 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clear()V ManagedChannelOrphanWrapper.java:110
#3 io.grpc.internal.ManagedChannelOrphanWrapper.shutdown()Lio/grpc/ManagedChannel; ManagedChannelOrphanWrapper.java:58
(stacktrace redacted)
Previous write of size 8 at 0x7fd2f7f37530 by thread T45 (mutexes: write M267260296638793720, write M267541771615505864, write M267823246592216728, write M267260296898451984, write M267541771875162784, write M267823246851873416):
#0 java.lang.ref.Reference.clear()V Reference.java:265
#1 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clearInternal()V ManagedChannelOrphanWrapper.java:118
#2 io.grpc.internal.ManagedChannelOrphanWrapper$ManagedChannelReference.clear()V ManagedChannelOrphanWrapper.java:110
#3 io.grpc.internal.ManagedChannelOrphanWrapper.shutdown()Lio/grpc/ManagedChannel; ManagedChannelOrphanWrapper.java:58
(stacktrace redacted)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.