Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize svg icons, fix JLab 1.1 issue #379

Merged
merged 1 commit into from Sep 6, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 5, 2019

This should fix #376.

The voila icons stopped showing in JupyterLab 1.1.

This change optimizes the svg files and sets the width and height to 16 (same as the core icons).

image

@jtpio
Copy link
Member Author

jtpio commented Sep 5, 2019

cc @maartenbreddels @martinRenou

I would like to make a new release of the extension once this gets in.

@vidartf
Copy link
Contributor

vidartf commented Sep 5, 2019

Should you keep the old versions? I think they are likely to be better for editing if you want to make changes. Or are the originals somewhere else?

@jtpio
Copy link
Member Author

jtpio commented Sep 5, 2019

Thanks @vidartf for double checking.

The icons are a copy of the voila-square.png version from the docs.

By the way, do you know why this started to break in JupyterLab 1.1?

@vidartf
Copy link
Contributor

vidartf commented Sep 5, 2019

I believe it might be this PR? jupyterlab/jupyterlab#6034

@jtpio
Copy link
Member Author

jtpio commented Sep 5, 2019

Yes

@jtpio
Copy link
Member Author

jtpio commented Sep 6, 2019

I think we can merge this one and make a new release.

The icons are still svg, and can be edited again if needed (or from the original square icon). Also the visual identity for voila will most likely change in the future.

@jtpio jtpio merged commit 035caad into voila-dashboards:master Sep 6, 2019
@jtpio jtpio deleted the fix-svg branch September 6, 2019 19:15
@adriendelsalle
Copy link

Great @jtpio ! Thank you!

@jtpio
Copy link
Member Author

jtpio commented Sep 6, 2019

@adriendelsalle A new version has been published.

To update: jupyter labextension update @jupyter-voila/jupyterlab-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing shortcut to launch voilà render in JLab notebooks
3 participants