Migrate the JupyterLab preview extension to JLab2 #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…available in the Browser
|
@jtpio This is working for me on JLab2.
|
echarles
changed the title
|
Thanks @echarles, this looks good! |
jtpio
reviewed
Mar 12, 2020
| @@ -66,7 +68,7 @@ class VoilaRenderButton | |||
| const button = new ToolbarButton({ | |||
| className: "voilaRender", | |||
| tooltip: "Render with Voila", | |||
| iconClassName: VOILA_ICON_CLASS, | |||
| iconClass: VOILA_ICON_CLASS, | |||
There was a problem hiding this comment.
Good thing the icons still support this 👍
We could update to LabIcon at a later stage (in a separate PR).
There was a problem hiding this comment.
Yeah I have been suprised it was still working fine with that. Upgrading to LabIcon also popped up in my mind for another PR.
There was a problem hiding this comment.
It was fixed in jupyterlab/jupyterlab#7947 (icons as css background)
|
Works well locally 👍
|
This was referenced Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intent is to migrate the JupyterLab preview extension to JLab2.
For now the code builds, I still need to check if the functionality is not degraded.