feat: improve auto import provider #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blake-newman
force-pushed
the
blake.newman/auto-import-improvements
branch
from
5152a9c
to
3d1828f
Compare
blake-newman
commented
Apr 11, 2023
| if (oldProgram && oldProgram !== this.getCurrentProgram()) { | ||
| this.hostProject.clearCachedExportInfoMap(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is the only logic that is not 1:1.
In summary calling updateGraph should:
- update rootFileNames if not truthy
- set the new program from the language service
- mark project as not dirty (sequential changes in same project won't retrigger updateGraph)
- If the program is not the same then clear the cached export info map.
blake-newman
commented
Apr 11, 2023
| projectVersion = newVersion; | ||
| project.hostProject.clearCachedExportInfoMap(); | ||
| project.clearCachedExportInfoMap(); | ||
| return project.dirty && project.updateGraph(); |
There was a problem hiding this comment.
This now matches the logic 1:1 with this method, if dirty then update graph.
blake-newman
commented
Apr 11, 2023
| @@ -403,7 +163,8 @@ function createBaseProject( | |||
| fileExists: this.program.fileExists, | |||
| // @ts-expect-error | |||
| directoryExists: this.program.directoryExists, | |||
| realpath: undefined, | |||
| // @ts-expect-error | |||
| realpath: this.program.realpath || this.projectService.host.realpath?.bind(this.projectService.host), | |||
There was a problem hiding this comment.
Reset this back to the original implementation, originally set this to undefined while triaging issue but should have been this originally.
blake-newman
force-pushed
the
blake.newman/auto-import-improvements
branch
2 times, most recently
from
2330b53
to
809b042
Compare
blake-newman
force-pushed
the
blake.newman/auto-import-improvements
branch
from
809b042
to
b617817
Compare
Ensure that auto import provider only clears cache when referencing symlink has changed, previously it would reset the cache when any changes to projects where made. This could be slow to pick up auto imports as it would trigger auto import to resolve every time change was made. Copy more source types over from source to make the code more typesafe and easier to reason with. Decouple auto import provider project to seperate file to make easier to work with.
blake-newman
force-pushed
the
blake.newman/auto-import-improvements
branch
from
b617817
to
5d6d42d
Compare
Explicitly proxy project methods to host, init project (constructor) seperately as this would proxy twice for auto import provider and allows seperate logic for creating language service.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that auto import provider only clears cache when referencing symlink has changed, previously it would reset the cache when any changes to projects where made. This could be slow to pick up auto imports as it would trigger auto import
to resolve every time change was made.
Copy more source types over from source to make the code more typesafe and easier to reason with.
Decouple auto import provider project to separate file to make easier to work with.