Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix emit signature to enable incremental work to function properly #150

Merged
merged 9 commits into from
Mar 13, 2024
Merged

fix emit signature to enable incremental work to function properly #150

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2a04a3b
refactor(language-service): reformat embedded document uri
johnsoncodehk Mar 11, 2024
99aa020
refactor(typescript): remove `getDocumentRegistry` API
johnsoncodehk Mar 11, 2024
c000700
refactor(language-service): rename `Result` interface to `ProviderRes…
johnsoncodehk Mar 12, 2024
2cc112c
fix: emit signature
skywalker512 Mar 13, 2024
fdb0ff7
Revert "refactor(language-service): rename `Result` interface to `Pro…
johnsoncodehk Mar 13, 2024
ad8c6a3
Revert "refactor(typescript): remove `getDocumentRegistry` API"
johnsoncodehk Mar 13, 2024
547f5ce
Revert "refactor(language-service): reformat embedded document uri"
johnsoncodehk Mar 13, 2024
b4dd350
Update decorateProgram.ts
johnsoncodehk Mar 13, 2024
de4c473
Revert "Update decorateProgram.ts"
johnsoncodehk Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/typescript/lib/node/decorateProgram.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@ export function decorateProgram(files: FileRegistry, program: ts.Program) {
// @ts-ignore
const getBindAndCheckDiagnostics = program.getBindAndCheckDiagnostics;

program.emit = (targetSourceFile, writeFile, cancellationToken, emitOnlyDtsFiles, customTransformers) => {
const result = emit(targetSourceFile, writeFile, cancellationToken, emitOnlyDtsFiles, customTransformers);
// @ts-ignore
program.emit = (targetSourceFile, writeFile, cancellationToken, emitOnlyDtsFiles, customTransformers, forceDtsEmit) => {
// @ts-ignore
const result = emit(targetSourceFile, writeFile, cancellationToken, emitOnlyDtsFiles, customTransformers, forceDtsEmit);
return {
emitSkipped: result.emitSkipped,
emittedFiles: result.emittedFiles,
Expand Down