Replace Windows symlinks with volta run scripts
#1755
+418
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using symlinks on Windows requires that our users enable Developer mode, which isn't always possible. For directory links, there is an easy solution: NTFS Junctions. These work the same as symlinks but do not require administrator privileges nor developer mode.
Rather than using symlinks, which require administrator privileges or developer mode on Windows, we can instead use small scripts that call out to 'volta run' to actually handle the execution of 3rd party binaries. This also adds a migration to a new v4 layout, which allows Windows installs to migrate immediately to using the script-based shims.
charlespierce
force-pushed
the
no_symlinks_windows
branch
from
2ddbf4a
to
fa04c75
Compare
|
Hey @charlespierce, great work! Did you find time to check how it affects performance? I'd be happy to help if some more work is needed to go forward with it, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1397
Info
volta run <package>.Changes
junctionto create NTFS junctions instead of directory symlinks (this part is directly copied from No more symlinks on Windows #1552)shimmodule to have different implementations ofcreatefor Unix and Windows..cmdscript that callsvolta runfor the shim. It also continues to create a custom Git Bash script, though that script is updated to now callvolta rundirectly, instead of calling the existing shim viacmd.exev4layout since the shim file on Windows is now<binary>.cmdinstead of<binary>.exe.v4that removes and regenerates the shims, making sure that the old symlinks are removed. The migration also updates any existing directory symlinks to use junctions as well.Tested
Notes