Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Overview page #639

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

sebastianrakel
Copy link
Member

@sebastianrakel sebastianrakel commented Oct 6, 2021

This should create a configurable frontpage, based on the work of @gdubicki

Based on PR #614

@sebastianrakel sebastianrakel changed the title Configurable front page Configurable Overview page Oct 6, 2021
@sebastianrakel sebastianrakel force-pushed the configurable_front_page branch 4 times, most recently from 8174b06 to bf9f053 Compare October 6, 2021 13:29
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #639 (bc0ddf5) into master (8244e29) will decrease coverage by 2.14%.
The diff coverage is 68.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
- Coverage   81.54%   79.40%   -2.15%     
==========================================
  Files          12       12              
  Lines         878      908      +30     
==========================================
+ Hits          716      721       +5     
- Misses        162      187      +25     
Impacted Files Coverage Δ
puppetboard/app.py 73.53% <64.00%> (-3.18%) ⬇️
puppetboard/default_settings.py 100.00% <100.00%> (ø)
puppetboard/docker_settings.py 100.00% <100.00%> (ø)
puppetboard/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef6429...bc0ddf5. Read the comment docs.

@gdubicki
Copy link
Member

gdubicki commented Oct 8, 2021

Unfortunately, you seem to hit the same issue as I did when I worked on this, @sebastianrakel .

When using the code from your branch as of now, if you set NODES_STATUS_DETAIL_ENABLED = False and RESOURCES_STATS_ENABLED = False then you are not making the query to get the number of nodes with each status and it results if showing zeros everywhere:

Screenshot 2021-10-08 at 18 12 51

@gdubicki gdubicki self-requested a review October 8, 2021 16:16
@sebastianrakel
Copy link
Member Author

I have to investigate this, it works a few days ago :D will have a look into it tomorrow

@gdubicki
Copy link
Member

Please rebase and let us know if it works for you, @sebastianrakel . 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants