Stringify wsdl-related error messages to avoid non-descriptive [objec…

…t Object] output. (#1037)
vpulim · Feb 12, 2019 · 570f5b3 · 570f5b3
1 parent 63bd7b7
commit 570f5b3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/wsdl.js b/lib/wsdl.js
@@ -1561,7 +1561,7 @@ WSDL.prototype.xmlToObject = function(xml, callback) {
         string = string || body.Fault.faultstring;
         detail = detail || body.Fault.detail;
 
-        var error = new Error(code + ': ' + string + (detail ? ': ' + detail : ''));
+        var error = new Error(code + ': ' + string + (detail ? ': ' + JSON.stringify(detail) : ''));
 
         error.root = root;
         throw error;

diff --git a/test/client-test.js b/test/client-test.js
@@ -820,7 +820,7 @@ var fs = require('fs'),
             server.close();
             server = null;
             assert.ok(err);
-            assert.strictEqual(err.message, 'Test: test error: test detail');
+            assert.strictEqual(err.message, 'Test: test error: "test detail"');
             assert.ok(result);
             assert.ok(body);
             done();